linux-kernel - RE: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device supports it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR12MB3238A5758B18B061204F264EFB479@BYAPR12MB3238.namprd12.prod.outlook.com>
Date:   Wed, 21 Apr 2021 08:41:55 +0000
From:   "Liang, Prike" <Prike.Liang@....com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Christoph Hellwig <hch@....de>
CC:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Sagi Grimberg <sagi@...mberg.me>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device supports
 it

[AMD Public Use]

According to BIOS guys the _PR3 should be always implemented for NVMe device on the onwards ASIC. This solution seems more simple and looks good to me.

Reviewed-by: Prike Liang <Prike.Liang@....com>

Thanks,
Prike
> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@...onical.com>
> Sent: Monday, April 19, 2021 2:58 PM
> To: Christoph Hellwig <hch@....de>
> Cc: Keith Busch <kbusch@...nel.org>; Jens Axboe <axboe@...com>; Sagi
> Grimberg <sagi@...mberg.me>; Deucher, Alexander
> <Alexander.Deucher@....com>; Liang, Prike <Prike.Liang@....com>; S-k,
> Shyam-sundar <Shyam-sundar.S-k@....com>; open list:NVM EXPRESS
> DRIVER <linux-nvme@...ts.infradead.org>; open list <linux-
> kernel@...r.kernel.org>
> Subject: Re: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device
> supports it
>
> On Mon, Apr 19, 2021 at 2:50 PM Christoph Hellwig <hch@....de> wrote:
> >
> > On Fri, Apr 16, 2021 at 05:13:44PM +0800, Kai-Heng Feng wrote:
> > > On AMD platforms that use s2idle, NVMe timeouts on s2idle resume,
> > > because their SMU FW may cut off NVMe power during sleep.
> >
> > We're already have a discussion on a proper quirk for thse broken
> > platforms on the linux-nvme list, please take part in that discussion.
>
> Thanks. I didn't notice v5 was sent the to mailing list.
> As of now, AMD folks are also reviewing this, and I believe this approach is
> less quirky.
>
> Kai-Heng