linux-kernel - Re: [PATCH] regulator: Avoid a double 'of_node_get' in 'regulator_of_get_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210421084357.GB64205@ediswmail.ad.cirrus.com>
Date:   Wed, 21 Apr 2021 08:43:57 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     <lgirdwood@...il.com>, <broonie@...nel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] regulator: Avoid a double 'of_node_get' in
 'regulator_of_get_init_node()'

On Tue, Apr 20, 2021 at 09:31:51PM +0200, Christophe JAILLET wrote:
> 'for_each_available_child_of_node()' already performs an 'of_node_get()'
> on child, so there is no need to perform another one before returning.
> Otherwise, a double 'get' is performed and a resource may never be
> released.
> 
> Fixes: 925c85e21ed8 ("regulator: Factor out location of init data OF node")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles