linux-kernel - Re: [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 11:48:59 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller

On Wed, Apr 21, 2021 at 11:32 AM Thomas Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
> On Wed, Apr 21, 2021 at 11:09:51AM +0300, Andy Shevchenko wrote:
> > On Tuesday, April 20, 2021, Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > wrote:
> >
> > > IDT 79RC3243x SoCs integrated a gpio controller, which handles up
> > > to 32 gpios. All gpios could be used as interrupt source.
> >
> >
> >
> > I would recommend looking for latest new drivers in GPIO subsystem to see
> > how you may improve yours.
>
> Could give me a better pointer to it ? I looked at a lot of gpio driver
> and took what fitted best.
>
> > Here just one question, why it can not be a module
>
> that's probably doable...
>
> > why arch_initcall() is used
>
> without that interrupts weren't avaiable early enough.
>
> > and why you put a dead code into it (see the first part of the
> > question)?
>
> hmm, pointer please ?

It's already in the question above, do your homework :-)

-- 
With Best Regards,
Andy Shevchenko