linux-kernel - Re: [PATCH 2/2] drivers: hv: Create a consistent pattern for checking Hyper-V hypercall status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 09:47:27 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Michael Kelley <mikelley@...rosoft.com>
Cc:     Joseph Salisbury <Joseph.Salisbury@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] drivers: hv: Create a consistent pattern for
 checking Hyper-V hypercall status

On Tue, Apr 20, 2021 at 09:30:08PM +0000, Michael Kelley wrote:
> From: Joseph Salisbury <joseph.salisbury@...ux.microsoft.com> Sent: Friday, April 16, 2021 5:43 PM
> > 
> > There is not a consistent pattern for checking Hyper-V hypercall status.
> > Existing code uses a number of variants.  The variants work, but a consistent
> > pattern would improve the readability of the code, and be more conformant
> > to what the Hyper-V TLFS says about hypercall status.
> > 
> > Implemented new helper functions hv_result(), hv_result_success(), and
> > hv_repcomp().  Changed the places where hv_do_hypercall() and related variants
> > are used to use the helper functions.
> > 
> > Signed-off-by: Joseph Salisbury <joseph.salisbury@...rosoft.com>
> > ---
> >  arch/x86/hyperv/hv_apic.c           | 16 +++++++++-------
> >  arch/x86/hyperv/hv_init.c           |  2 +-
> >  arch/x86/hyperv/hv_proc.c           | 25 ++++++++++---------------
> >  arch/x86/hyperv/irqdomain.c         |  6 +++---
> >  arch/x86/hyperv/mmu.c               |  8 ++++----
> >  arch/x86/hyperv/nested.c            |  8 ++++----
> >  arch/x86/include/asm/mshyperv.h     |  1 +
> >  drivers/hv/hv.c                     |  2 +-
> >  drivers/pci/controller/pci-hyperv.c |  2 +-
> >  include/asm-generic/mshyperv.h      | 25 ++++++++++++++++++++-----
> >  10 files changed, 54 insertions(+), 41 deletions(-)
> 
> Wei -- I have gone through these changes reasonably carefully, but
> your review of the Linux-in-the-root-partition changes would be a good
> double-check.  It's too easy to get the sense of the tests backwards. :-(

The code looks correct to me.

> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>

Thanks. I will apply this series to hyperv-next shortly.

Wei.