linux-kernel - Re: [PATCH] xhci: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bf6144c-9385-d7ff-a30c-f0bb17f9c2e6@linux.alibaba.com>
Date:   Wed, 21 Apr 2021 18:39:48 +0800
From:   Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: remove unused variable

On 2021/4/1 18:44, Greg KH wrote:
> On Thu, Apr 01, 2021 at 06:17:15PM +0800, Jiapeng Chong wrote:
>> Fix the following clang warning:
>>
>> drivers/usb/host/xhci.c:1346:15: warning: variable ‘len’ set but not
>> used [-Wunused-but-set-variable].
>>
>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
>> ---
>>   drivers/usb/host/xhci.c | 8 +++-----
>>   1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> index 1975016..0ead09c 100644
>> --- a/drivers/usb/host/xhci.c
>> +++ b/drivers/usb/host/xhci.c
>> @@ -1343,7 +1343,6 @@ static bool xhci_urb_temp_buffer_required(struct usb_hcd *hcd,
>>   
>>   static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
>>   {
>> -	unsigned int len;
>>   	unsigned int buf_len;
>>   	enum dma_data_direction dir;
>>   
>> @@ -1359,10 +1358,9 @@ static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
>>   				 dir);
>>   
>>   	if (usb_urb_dir_in(urb))
>> -		len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
>> -					   urb->transfer_buffer,
>> -					   buf_len,
>> -					   0);
>> +		sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
>> +				     urb->transfer_buffer,
>> +				     buf_len, 0);
>>   
>>   	urb->transfer_flags &= ~URB_DMA_MAP_SINGLE;
>>   	kfree(urb->transfer_buffer);
>> -- 
>> 1.8.3.1
>>
> 
> Why resubmit this same change when I rejected it in the past?
> 
> {sigh}
> 
> greg k-h
> 

Thanks for reminding us. We'll pay more attention next time.