linux-kernel - Re: [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 13:46:43 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller

On Wed, Apr 21, 2021 at 1:37 PM Thomas Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
>
> On Wed, Apr 21, 2021 at 12:54:53PM +0300, Andy Shevchenko wrote:
> > As I promised you, I will do a deep review later on, I'm giving you
> > time to find issues yourself. That's how you may actually learn the
> > things. It's solely your choice to follow or not, my promise will be
> > kept and you will get an answer anyway.
>
> so let's make it a challenge ;-)
>
> I see I could use gpiochip_get_data() in few place.
>
> Is there more you see ?

Good.

For now:
- dead code due to driver not being compiled as module
- too verbose Kconfig machinery (it's not about the "help" part!)
- open coded stuff in IRQ handler
- whatever you found.

-- 
With Best Regards,
Andy Shevchenko