linux-kernel - Re: [PATCH v3 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210421113433.88881-1-kuniyu@amazon.co.jp>
Date:   Wed, 21 Apr 2021 20:34:33 +0900
From:   Kuniyuki Iwashima <kuniyu@...zon.co.jp>
To:     <andrii.nakryiko@...il.com>
CC:     <andrii@...nel.org>, <ast@...nel.org>, <benh@...zon.com>,
        <bpf@...r.kernel.org>, <daniel@...earbox.net>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kafai@...com>,
        <kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.co.jp>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE.

From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
Date:   Tue, 20 Apr 2021 15:57:54 -0700
> On Tue, Apr 20, 2021 at 8:45 AM Kuniyuki Iwashima <kuniyu@...zon.co.jp> wrote:
> >
> > This patch adds a test for BPF_SK_REUSEPORT_SELECT_OR_MIGRATE and
> > removes 'static' from settimeo() in network_helpers.c.
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
> > ---
> 
> Almost everything in prog_tests/migrate_reuseport.c should be static,
> functions and variables. Except the test_migrate_reuseport, of course.
> 
> But thank you for using ASSERT_xxx()! :)

Ah, I'll fix them in the next spin :)
Thank you!


> 
> >  tools/testing/selftests/bpf/network_helpers.c |   2 +-
> >  tools/testing/selftests/bpf/network_helpers.h |   1 +
> >  .../bpf/prog_tests/migrate_reuseport.c        | 483 ++++++++++++++++++
> >  .../bpf/progs/test_migrate_reuseport.c        |  51 ++
> >  4 files changed, 536 insertions(+), 1 deletion(-)
> >  create mode 100644 tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
> >  create mode 100644 tools/testing/selftests/bpf/progs/test_migrate_reuseport.c
> >
> 
> [...]