linux-kernel - Re: [PATCH 2/2] csky: add CONFIG_CPU_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bb2a70f-7f3a-26f1-98ed-e6b7b2220798@infradead.org>
Date:   Tue, 20 Apr 2021 20:01:19 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Wang Junqiang <wangjunqiang@...as.ac.cn>, guoren@...nel.org
Cc:     guoren@...ux.alibaba.com, linux-csky@...r.kernel.org,
        linux-kernel@...r.kernel.org, Li Weiwei <liweiwei@...as.ac.cn>
Subject: Re: [PATCH 2/2] csky: add CONFIG_CPU_HAS_MATHEMU and use in traps

Hi--

On 4/20/21 7:49 PM, Wang Junqiang wrote:
> diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> index 34e91224adc3..a414225570c1 100644
> --- a/arch/csky/Kconfig
> +++ b/arch/csky/Kconfig
> @@ -97,6 +97,9 @@ config CPU_HAS_CACHEV2
>  config CPU_HAS_FPUV2
>  	bool
>  
> +config CPU_HAS_MATHEMU
> +	bool
> +

Why do you have this new kconfig symbol two times in the same file?

>  config CPU_HAS_HILO
>  	bool
>  
> @@ -281,6 +284,11 @@ config CPU_HAS_VDSP
>  	bool "CPU has VDSP coprocessor"
>  	depends on CPU_HAS_FPU && CPU_HAS_FPUV2
>  
> +config CPU_HAS_MATHEMU
> +	bool "CPU has FPU Mathemu Instructions"
> +	depends on CPU_CK810 || CPU_CK860
> +	default n
> +
>  config CPU_HAS_FPU
>  	bool "CPU has FPU coprocessor"
>  	depends on CPU_CK807 || CPU_CK810 || CPU_CK860


thanks.
-- 
~Randy