linux-kernel - Re: [PATCH] csky: uaccess.h: Coding convention with asm generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210421144804.GA3969416@infradead.org>
Date:   Wed, 21 Apr 2021 15:48:04 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     guoren@...nel.org
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        linux-csky@...r.kernel.org, linux-arch@...r.kernel.org,
        Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH] csky: uaccess.h: Coding convention with asm generic

On Wed, Apr 21, 2021 at 08:54:15AM +0000, guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> Using asm-generic/uaccess.h to prevent duplicated code:
>  - Add user_addr_max which mentioned in generic uaccess.h
>  - Remove custom definitions of KERNEL/USER_DS, get/set_fs,
>    uaccess_kerenl

Instead of using the generic definitions removing support for set_fs
entirely would be much preferred.  The series in linux-next for mips,
or the riscv version that landed in 5.10 might be good examples.