linux-kernel - Re: [PATCH 122/190] Revert "HID: logitech: check the return value of create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2104211719330.18270@cbobk.fhfr.pm>
Date:   Wed, 21 Apr 2021 17:20:45 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:     linux-kernel@...r.kernel.org, Kangjie Lu <kjlu@....edu>
Subject: Re: [PATCH 122/190] Revert "HID: logitech: check the return value
 of create_singlethread_workqueue"

On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote:

> This reverts commit 6c44b15e1c9076d925d5236ddadf1318b0a25ce2.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Kangjie Lu <kjlu@....edu>
> Cc: Jiri Kosina <jkosina@...e.cz>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

This particular one doesn't have to be reverted, I have reviewed it again 
and it does fix an actual bug.

Thanks,

-- 
Jiri Kosina
SUSE Labs