linux-kernel - Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa867751-0019-1950-bdc4-019737f29e4b@linux.intel.com>
Date:   Wed, 21 Apr 2021 10:47:21 -0500
From:   "Zanussi, Tom" <tom.zanussi@...ux.intel.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     peterz@...radead.org, acme@...nel.org, mingo@...nel.org,
        kan.liang@...ux.intel.com, dave.jiang@...el.com,
        tony.luck@...el.com, dan.j.williams@...el.com,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor
 support



On 4/21/2021 10:03 AM, Vinod Koul wrote:
> On 21-04-21, 07:50, Zanussi, Tom wrote:
> 
>>>>>> +static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
>>>>>> +			    char *buf);
>>>>>> +
>>>>>> +static cpumask_t		perfmon_dsa_cpu_mask;
>>>>>> +static bool			cpuhp_set_up;
>>>>>> +static enum cpuhp_state		cpuhp_slot;
>>>>>> +
>>>>>> +static DEVICE_ATTR_RO(cpumask);
>>>>>
>>>>> Pls document these new attributes added
>>>
>>> ?
>>>
>>
>> Yes, I'll add comments to all the attributes (also I'm assuming they don't need to be documented elsewhere).
> 
> They need to be, all new sysfs attributes are ABI and need to be
> documented in Documentation/ABI/
> 

OK, will do that as well, thanks for letting me know.

Tom

> Thanks
>