linux-kernel - Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Apr 2021 13:30:00 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Jason Gunthorpe <jgg@...pe.ca>,
        Marion et Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        tj@...nel.org, jiangshanlai@...il.com, saeedm@...dia.com,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros
 accept a format specifier

On 4/22/21 11:00 AM, Leon Romanovsky wrote:
> On Thu, Apr 22, 2021 at 10:12:33AM -0700, Bart Van Assche wrote:
>> On 4/22/21 5:24 AM, Jason Gunthorpe wrote:
>>> On Mon, Apr 19, 2021 at 01:02:34PM -0700, Bart Van Assche wrote:
>>>> On 4/18/21 11:36 PM, Marion et Christophe JAILLET wrote:
>>>>> The list in To: is the one given by get_maintainer.pl. Usualy, I only
>>>>> put the ML in Cc: I've run the script on the 2 patches of the serie
>>>>> and merged the 2 lists. Everyone is in the To: of the cover letter
>>>>> and of the 2 patches.
>>>>>
>>>>> If Théo is "Tejun Heo" (  (maintainer:WORKQUEUE) ), he is already in
>>>>> the To: line.
>>>> Linus wants to see a "Cc: ${maintainer}" tag in patches that he receives
>>>> from a maintainer and that modify another subsystem than the subsystem
>>>> maintained by that maintainer.
>>>
>>> Really? Do you remember a lore link for this?
>>
>> Last time I saw Linus mentioning this was a few months ago.
>> Unfortunately I cannot find that message anymore.
>>
>>> Generally I've been junking the CC lines (vs Andrew at the other
>>> extreme that often has 10's of CC lines)
>>
>> Most entries in the MAINTAINERS file have one to three email addresses
>> so I'm surprised to read that Cc-ing maintainer(s) could result in tens
>> of Cc lines?
> 
> git log mm/
> 
> commit 2b8305260fb37fc20e13f71e13073304d0a031c8
> Author: Alexander Potapenko <glider@...gle.com>
> Date:   Thu Feb 25 17:19:21 2021 -0800
> 
>      kfence, kasan: make KFENCE compatible with KASAN
> 
>      Make KFENCE compatible with KASAN. Currently this helps test KFENCE
>      itself, where KASAN can catch potential corruptions to KFENCE state, or
>      other corruptions that may be a result of freepointer corruptions in the
>      main allocators.
> 
>      [akpm@...ux-foundation.org: merge fixup]
>      [andreyknvl@...gle.com: untag addresses for KFENCE]
>        Link: https://lkml.kernel.org/r/9dc196006921b191d25d10f6e611316db7da2efc.1611946152.git.andreyknvl@google.com
> 
>      Link: https://lkml.kernel.org/r/20201103175841.3495947-7-elver@google.com
>      Signed-off-by: Marco Elver <elver@...gle.com>
>      Signed-off-by: Alexander Potapenko <glider@...gle.com>
>      Signed-off-by: Andrey Konovalov <andreyknvl@...gle.com>
>      Reviewed-by: Dmitry Vyukov <dvyukov@...gle.com>
>      Reviewed-by: Jann Horn <jannh@...gle.com>
>      Co-developed-by: Marco Elver <elver@...gle.com>
>      Cc: Andrey Konovalov <andreyknvl@...gle.com>
>      Cc: Andrey Ryabinin <aryabinin@...tuozzo.com>
>      Cc: Andy Lutomirski <luto@...nel.org>
>      Cc: Borislav Petkov <bp@...en8.de>
>      Cc: Catalin Marinas <catalin.marinas@....com>
>      Cc: Christopher Lameter <cl@...ux.com>
>      Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>      Cc: David Rientjes <rientjes@...gle.com>
>      Cc: Eric Dumazet <edumazet@...gle.com>
>      Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>      Cc: Hillf Danton <hdanton@...a.com>
>      Cc: "H. Peter Anvin" <hpa@...or.com>
>      Cc: Ingo Molnar <mingo@...hat.com>
>      Cc: Joern Engel <joern@...estorage.com>
>      Cc: Jonathan Corbet <corbet@....net>
>      Cc: Joonsoo Kim <iamjoonsoo.kim@....com>
>      Cc: Kees Cook <keescook@...omium.org>
>      Cc: Mark Rutland <mark.rutland@....com>
>      Cc: Paul E. McKenney <paulmck@...nel.org>
>      Cc: Pekka Enberg <penberg@...nel.org>
>      Cc: Peter Zijlstra <peterz@...radead.org>
>      Cc: SeongJae Park <sjpark@...zon.de>
>      Cc: Thomas Gleixner <tglx@...utronix.de>
>      Cc: Vlastimil Babka <vbabka@...e.cz>
>      Cc: Will Deacon <will@...nel.org>
>      Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>      Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

But where does that Cc-list come from? If I extract that patch and run 
the get_maintainer.pl script, the following output appears:

$ git format-patch -1 2b8305260fb37fc20e13f71e13073304d0a031c8
0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch
$ scripts/get_maintainer.pl 
0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch
Alexander Potapenko <glider@...gle.com> (maintainer:KFENCE)
Marco Elver <elver@...gle.com> (maintainer:KFENCE)
Dmitry Vyukov <dvyukov@...gle.com> (reviewer:KFENCE)
Andrey Ryabinin <ryabinin.a.a@...il.com> (maintainer:KASAN)
Andrey Konovalov <andreyknvl@...il.com> (reviewer:KASAN)
Andrew Morton <akpm@...ux-foundation.org> (maintainer:MEMORY MANAGEMENT)
kasan-dev@...glegroups.com (open list:KFENCE)
linux-kernel@...r.kernel.org (open list)
linux-mm@...ck.org (open list:MEMORY MANAGEMENT)

Additionally, please note that in my email I was referring to the 
MAINTAINERS file. I do not use the get_maintainers.pl script but instead 
select the Cc-list manually based on what I find in the MAINTAINERS file.

Thanks,

Bart.