linux-kernel - Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2104221053500.44318@angie.orcam.me.uk>
Date:   Thu, 22 Apr 2021 11:12:40 +0200 (CEST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
cc:     "H. Nikolaus Schaller" <hns@...delico.com>,
        Arnd Bergmann <arnd@...db.de>,
        Huacai Chen <chenhuacai@...nel.org>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-arch@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be
 zero

On Thu, 22 Apr 2021, Thomas Bogendoerfer wrote:

> >  Thomas, as this mistake has spread across three out of these patches,
> > both in change descriptions and actual code, would you mind dropping the 
> > series from mips-next altogether and I'll respin the series with all 
> > these issues corrected?
> 
> I'm sorry, but I don't rebase mips-next and the patches have been pushed
> out before I received this mail.

 Hmm, what about changes known to actually break something then?  Like 
with R6 here?  Those will undoubtedly cause someone a headache with 
bisection sometime in the future.  Are you sure your policy is the best 
possible?

 NB, I have benchmarked the update with my DECstation, however my Malta 
has not come up after a reboot last evening and neither it has after a few 
remote power cycles.  I have planned a visit in my lab next week anyway, 
so I'll see what has happened there; hopefully I'm able to bring the board 
back to life as I find it valuable for my purposes.  I had to replace the 
PSU it came with already a couple years back and the new one is supposedly 
high-quality, so I fear it's the board itself.

 Meanwhile I'll be able to give DECstation figures only.  I guess such 
limited results will suffice if I post the fix as an update rather than 
replacement.

  Maciej