linux-kernel - Re: [PATCH] x86/mm: Fix copy&paste error in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82c81cd7-bced-d533-56f3-1d75c9f4593b@gmail.com>
Date:   Thu, 22 Apr 2021 17:29:55 +0800
From:   Ts'o <jojing64@...il.com>
To:     x86@...nel.org, linux-kernel@...r.kernel.org
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org
Subject: Re: [PATCH] x86/mm: Fix copy&paste error in comments


On 20/4/2021 1:34 pm, Cao jin wrote:
> Direct page mapping in bottom-up way will allocate memory from low
> address for page structures in a range, which is the *bottom*,
> not the *end*.
> 
> Signed-off-by: Cao jin <jojing64@...il.com>
> ---
>   arch/x86/mm/init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index e26f5c5c6565..bc2f871c75f1 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -663,7 +663,7 @@ static void __init memory_map_bottom_up(unsigned long map_start,
>   	/*
>   	 * We start from the bottom (@map_start) and go to the top (@map_end).
>   	 * The memblock_find_in_range() gets us a block of RAM from the
> -	 * end of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
> +	 * bottom of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
>   	 * for page table.
>   	 */

FYI: There is exactly the same sentence in memory_map_top_down(), looks 
like a copy & paste error to me.

--
Cao jin