linux-kernel - Re: [PATCH 3/3] serial: stm32: defer sysrq processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <496a5b3e-84e3-99a7-0b4f-c8b27cda34f4@foss.st.com>
Date:   Thu, 22 Apr 2021 09:36:16 +0000
From:   Valentin CARON - foss <valentin.caron@...s.st.com>
To:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Jiri Slaby <jirislaby@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE - foss <alexandre.torgue@...s.st.com>,
        "dillon.minfei@...il.com" <dillon.minfei@...il.com>,
        Erwan LE-RAY - foss <erwan.leray@...s.st.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] serial: stm32: defer sysrq processing

Hi,

On 4/16/21 4:05 PM, Johan Hovold wrote:
> Use the uart_unlock_and_check_sysrq() helper to defer sysrq processing
> until receive processing is done and the port lock has been released.
>
> This allows cleaning up the console_write() implementation by not having
> to work around the recursive sysrq case (by dropping locking completely)
> and also makes the console code work with PREEMPT_RT by no longer
> relying on local_irq_save().
>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Valentin Caron<valentin.caron@...s.st.com>

> ---
>   drivers/tty/serial/stm32-usart.c | 16 ++++++----------
>   1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
> index 3524ed2c0c73..24a1dfe7058b 100644
> --- a/drivers/tty/serial/stm32-usart.c
> +++ b/drivers/tty/serial/stm32-usart.c
> @@ -270,12 +270,12 @@ static void stm32_usart_receive_chars(struct uart_port *port, bool threaded)
>   			}
>   		}
>   
> -		if (uart_handle_sysrq_char(port, c))
> +		if (uart_prepare_sysrq_char(port, c))
>   			continue;
>   		uart_insert_char(port, sr, USART_SR_ORE, c, flag);
>   	}
>   
> -	spin_unlock(&port->lock);
> +	uart_unlock_and_check_sysrq(port);
>   
>   	tty_flip_buffer_push(tport);
>   }
> @@ -1430,13 +1430,10 @@ static void stm32_usart_console_write(struct console *co, const char *s,
>   	u32 old_cr1, new_cr1;
>   	int locked = 1;
>   
> -	local_irq_save(flags);
> -	if (port->sysrq)
> -		locked = 0;
> -	else if (oops_in_progress)
> -		locked = spin_trylock(&port->lock);
> +	if (oops_in_progress)
> +		locked = spin_trylock_irqsave(&port->lock, flags);
>   	else
> -		spin_lock(&port->lock);
> +		spin_lock_irqsave(&port->lock, flags);
>   
>   	/* Save and disable interrupts, enable the transmitter */
>   	old_cr1 = readl_relaxed(port->membase + ofs->cr1);
> @@ -1450,8 +1447,7 @@ static void stm32_usart_console_write(struct console *co, const char *s,
>   	writel_relaxed(old_cr1, port->membase + ofs->cr1);
>   
>   	if (locked)
> -		spin_unlock(&port->lock);
> -	local_irq_restore(flags);
> +		spin_unlock_irqrestore(&port->lock, flags);
>   }
>   
>   static int stm32_usart_console_setup(struct console *co, char *options)