linux-kernel - Re: [PATCH 089/190] Revert "PCI: endpoint: Fix a potential NULL pointer dereference"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIFEhR2r9rF1m779@kroah.com>
Date:   Thu, 22 Apr 2021 11:40:21 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     kishon@...com, linux-kernel@...r.kernel.org,
        Kangjie Lu <kjlu@....edu>
Subject: Re: [PATCH 089/190] Revert "PCI: endpoint: Fix a potential NULL
 pointer dereference"

On Thu, Apr 22, 2021 at 10:31:11AM +0100, Lorenzo Pieralisi wrote:
> On Wed, Apr 21, 2021 at 02:59:24PM +0200, Greg Kroah-Hartman wrote:
> > This reverts commit 507b820009a457afa78202da337bcb56791fbb12.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> > 
> > Cc: Kangjie Lu <kjlu@....edu>
> > Cc: commit log and code update]
> 
> Hi Greg,
> 
> first off, thank you for doing this.
> 
> This Cc should be fixed up if we go ahead with the revert (I can
> take the revert via the PCI tree and fix it up myself).
> 
> I totally understand your concern (and the nuisance it is causing), the
> commit we are reverting looked and looks legit - just let me know
> how it is best to handle this please.

I'll fix up all improper Cc: lines, that was my dumb script trying to
catch who was on the reverted patch, when I apply these.

I can take this through my tree, but as you said, if the original commit
here really is fine, that's great, I'll drop this.

Thanks for the review!

greg k-h