linux-kernel - Re: [PATCH v3 3/3] thermal: create a helper __thermal_cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6b27171-d43c-34d9-adac-20f4d7d21fc8@linaro.org>
Date:   Thu, 22 Apr 2021 12:26:13 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Lukasz Luba <lukasz.luba@....com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        amitk@...nel.org, rui.zhang@...el.com
Subject: Re: [PATCH v3 3/3] thermal: create a helper __thermal_cdev_update()
 without a lock

On 22/04/2021 10:21, Lukasz Luba wrote:
> 
> 
> On 4/22/21 8:58 AM, Daniel Lezcano wrote:
>> On 21/04/2021 19:41, Lukasz Luba wrote:
>>> There is a need to have a helper function which updates cooling device
>>> state from the governors code. With this change governor can use
>>> lock and unlock while calling helper function. This avoid unnecessary
>>> second time lock/unlock which was in previous solution present in
>>> governor implementation. This new helper function must be called
>>> with mutex 'cdev->lock' hold.
>>>
>>> The changed been discussed and part of code presented in thread:
>>> https://lore.kernel.org/linux-pm/20210419084536.25000-1-lukasz.luba@arm.com/
>>>
>>>
>>> Co-developed-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>>> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
>>> ---
>>>   drivers/thermal/gov_power_allocator.c |  5 +----
>>>   drivers/thermal/thermal_core.h        |  1 +
>>>   drivers/thermal/thermal_helpers.c     | 28 +++++++++++++++++----------
>>
>> Why not add this patch first (without the ipa changes) and then replace
>> patch 2 by using the new function ? That will prevent to go back and
>> forth.
> 
> I thought that it would show also the motivation and usage in the
> governor. I can had this patch as first in the set, but then I thought
> about this example.
> I can change it if you like in v4.

Yes, please. I think it is more logical.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog