linux-kernel - Re: [PATCH] efifb: Check efifb_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPKp9uYEwNfmBndCWt5BSZ7VQ+JHAhzd6aBsN8WO1nmMUQ2Mcw@mail.gmail.com>
Date:   Thu, 22 Apr 2021 11:41:11 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Alex Deucher <alexdeucher@...il.com>,
        "open list:EFIFB FRAMEBUFFER DRIVER" <linux-fbdev@...r.kernel.org>,
        "open list:FRAMEBUFFER LAYER" <dri-devel@...ts.freedesktop.org>,
        pjones@...hat.com
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        open list <linux-kernel@...r.kernel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Alex Deucher <alexander.deucher@....com>,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH] efifb: Check efifb_pci_dev before using it

On Wed, Apr 14, 2021 at 8:20 AM Alex Deucher <alexdeucher@...il.com> wrote:
>
> On Tue, Apr 13, 2021 at 2:37 PM Daniel Vetter <daniel@...ll.ch> wrote:
> >
> > On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher <alexdeucher@...il.com> wrote:
> > >
> > > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng
> > > <kai.heng.feng@...onical.com> wrote:
> > > >
> > > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not
> > > > a PCI device.
> > > >
> > > > So make sure efifb_pci_dev is found before using it.
> > > >
> > > > Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0")
> > > > BugLink: https://bugs.launchpad.net/bugs/1922403
> > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> > >
> > > Reviewed-by: Alex Deucher <alexander.deucher@....com>
> >
> > fbdev is in drm-misc, so maybe you can push this one too?
>
> Yes, pushed.  Thanks!
>

Can we have this pushed into the branch that gets merged into linux-next.
I still don't see this fix in -next and we are unable to do testing on our
platform as we hit a boot crash without this as reported in [1]. We prefer
running tests on -next without any additional patches or reverts, hence
the nagging, sorry for that.

Regards,
Sudeep

[1] https://lore.kernel.org/dri-devel/20210415102224.2764054-1-sudeep.holla@arm.com/