linux-kernel - Re: [RFC PATCH linux-next] kernel/resource: __region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdbegA4iHJcT9s-MbU2nHHAKdaRFA_J8DqzR5BKhh-htg@mail.gmail.com>
Date:   Thu, 22 Apr 2021 13:46:40 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Alistair Popple <apopple@...dia.com>, kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH linux-next] kernel/resource: __region_intersects() can
 be static

On Thu, Apr 22, 2021 at 4:30 AM kernel test robot <lkp@...el.com> wrote:

Can you generate a commit message as well?
Otherwise looks valid to me, thanks!

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
>  resource.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 8faae19f8236e..a4bc6f66136c6 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn)
>  }
>  EXPORT_SYMBOL_GPL(page_is_ram);
>
> -int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
> -                       unsigned long desc)
> +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
> +                              unsigned long desc)
>  {
>         struct resource res;
>         int type = 0; int other = 0;



-- 
With Best Regards,
Andy Shevchenko