linux-kernel - Re: [PATCH 026/190] Revert "usb: dwc3: pci: Fix reference count leak in dwc3_pci_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fszimtpy.fsf@kernel.org>
Date:   Thu, 22 Apr 2021 14:42:01 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Aditya Pakki <pakki001@....edu>
Subject: Re: [PATCH 026/190] Revert "usb: dwc3: pci: Fix reference count
 leak in dwc3_pci_resume_work"


Hi,

Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:

> This reverts commit 2655971ad4b34e97dd921df16bb0b08db9449df7.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Aditya Pakki <pakki001@....edu>
> Cc: Felipe Balbi <balbi@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/usb/dwc3/dwc3-pci.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 4c5c6972124a..0c0619f7b1a7 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -226,10 +226,8 @@ static void dwc3_pci_resume_work(struct work_struct *work)
>  	int ret;
>  
>  	ret = pm_runtime_get_sync(&dwc3->dev);
> -	if (ret) {
> -		pm_runtime_put_sync_autosuspend(&dwc3->dev);
> +	if (ret)
>  		return;
> -	}

this was a valid fix. pm_runtime_get_sync() leaves an unbalanced get on
the runtime usage counter.

It's okay if you prefer to revert it and have a new review cycle for
this, though.


-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)