linux-kernel - Re: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Apr 2021 14:09:30 +0200
From:   Christian König <christian.koenig@....com>
To:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        Huang Rui <ray.huang@....com>, David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses



Am 20.04.21 um 10:53 schrieb Daniel Vetter:
> On Fri, Apr 16, 2021 at 05:32:52PM +0200, Christian König wrote:
>> Am 16.04.21 um 16:37 schrieb Lee Jones:
>>> Fixes the following W=1 kernel build warning(s):
>>>
>>>    drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX'
>>>    drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead
>>>    drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'ctx' not described in 'ttm_global_swapout'
>>>    drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'gfp_flags' not described in 'ttm_global_swapout'
>>>    drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead
>>>
>>> Cc: Christian Koenig <christian.koenig@....com>
>>> Cc: Huang Rui <ray.huang@....com>
>>> Cc: David Airlie <airlied@...ux.ie>
>>> Cc: Daniel Vetter <daniel@...ll.ch>
>>> Cc: dri-devel@...ts.freedesktop.org
>>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
>> Reviewed-by: Christian König <christian.koenig@....com>
> Can you pls also land all the patches you reviewed from Lee into
> drm-misc-next? Just so they wont' get lost. Will all head in for 5.14.

Alex took care of the amdgpu patches and I've just pushed the TTM and 
the scheduler patch to drm-misc-next.

Christian.

> -Daniel
>>> ---
>>>    drivers/gpu/drm/ttm/ttm_device.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c
>>> index 9b787b3caeb50..a8bec8358350d 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_device.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_device.c
>>> @@ -36,7 +36,7 @@
>>>    #include "ttm_module.h"
>>> -/**
>>> +/*
>>>     * ttm_global_mutex - protecting the global state
>>>     */
>>>    DEFINE_MUTEX(ttm_global_mutex);
>>> @@ -104,7 +104,7 @@ static int ttm_global_init(void)
>>>    	return ret;
>>>    }
>>> -/**
>>> +/*
>>>     * A buffer object shrink method that tries to swap out the first
>>>     * buffer object on the global::swap_lru list.
>>>     */