linux-kernel - [irqchip: irq/irqchip-next] irqchip/tb10x: Use 'fallthrough' to eliminate a warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Apr 2021 13:07:24 -0000
From:   "irqchip-bot for Randy Dunlap" <tip-bot2@...utronix.de>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Christian Ruppert <christian.ruppert@...lis.com>
Subject: [irqchip: irq/irqchip-next] irqchip/tb10x: Use 'fallthrough' to
 eliminate a warning

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     a6992bbe9774e044d3d0f973593d655c53efe089
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/a6992bbe9774e044d3d0f973593d655c53efe089
Author:        Randy Dunlap <rdunlap@...radead.org>
AuthorDate:    Wed, 21 Apr 2021 22:16:20 -07:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Thu, 22 Apr 2021 13:53:33 +01:00

irqchip/tb10x: Use 'fallthrough' to eliminate a warning

Use the 'fallthrough' macro to document that this switch case
does indeed fall through to the next case.

../drivers/irqchip/irq-tb10x.c: In function 'tb10x_irq_set_type':
../drivers/irqchip/irq-tb10x.c:62:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
   62 |   flow_type = IRQ_TYPE_LEVEL_LOW;
../drivers/irqchip/irq-tb10x.c:63:2: note: here
   63 |  case IRQ_TYPE_LEVEL_LOW:
      |  ^~~~

Fixes: b06eb0173ef1 ("irqchip: Add TB10x interrupt controller driver")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Marc Zyngier <maz@...nel.org>
Cc: Christian Ruppert <christian.ruppert@...lis.com>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Link: https://lore.kernel.org/r/20210422051620.23021-1-rdunlap@infradead.org
---
 drivers/irqchip/irq-tb10x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-tb10x.c b/drivers/irqchip/irq-tb10x.c
index 9e45649..9a63b02 100644
--- a/drivers/irqchip/irq-tb10x.c
+++ b/drivers/irqchip/irq-tb10x.c
@@ -60,6 +60,7 @@ static int tb10x_irq_set_type(struct irq_data *data, unsigned int flow_type)
 		break;
 	case IRQ_TYPE_NONE:
 		flow_type = IRQ_TYPE_LEVEL_LOW;
+		fallthrough;
 	case IRQ_TYPE_LEVEL_LOW:
 		mod ^= im;
 		pol ^= im;