linux-kernel - Re: [PATCH] PM / wakeup: remove redundant assignment to variable retval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ge7e68vTB3vvcz9OThp32X0=+XaQPrPQCGf0xM9uCi0Q@mail.gmail.com>
Date:   Thu, 22 Apr 2021 15:26:32 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / wakeup: remove redundant assignment to variable retval

On Fri, Apr 16, 2021 at 2:44 PM Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> The variable retval is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/base/power/wakeup_stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/power/wakeup_stats.c b/drivers/base/power/wakeup_stats.c
> index 5ade7539ac02..924fac493c4f 100644
> --- a/drivers/base/power/wakeup_stats.c
> +++ b/drivers/base/power/wakeup_stats.c
> @@ -137,7 +137,7 @@ static struct device *wakeup_source_device_create(struct device *parent,
>                                                   struct wakeup_source *ws)
>  {
>         struct device *dev = NULL;
> -       int retval = -ENODEV;
> +       int retval;
>
>         dev = kzalloc(sizeof(*dev), GFP_KERNEL);
>         if (!dev) {
> --

Applied as 5.13 material, thanks!