linux-kernel - Re: [PATCH v4 4/4] pinctrl: add rsel setting on MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Apr 2021 10:10:46 +0800
From:   zhiyong tao <zhiyong.tao@...iatek.com>
To:     Sean Wang <sean.wang@...nel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        srv_heupstream <srv_heupstream@...iatek.com>,
        Hui Liu (刘辉) 
        <Hui.Liu@...iatek.com>,
        Eddie Huang (黃智傑) 
        <eddie.huang@...iatek.com>,
        Po Xu (徐坡) 
        <ot_po.xu@...iatek.com>,
        "Biao Huang (黄彪)" 
        <Biao.Huang@...iatek.com>,
        Hongzhou Yang <hongzhou.yang@...iatek.com>,
        Sean Wang <Sean.Wang@...iatek.com>,
        Seiya Wang (王迺君) 
        <seiya.wang@...iatek.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v4 4/4] pinctrl: add rsel setting on MT8195

On Tue, 2021-04-20 at 11:50 +0800, Sean Wang wrote:
> On Mon, Apr 12, 2021 at 10:57 PM Zhiyong Tao <zhiyong.tao@...iatek.com> wrote:
> 
> <snip>
> > @@ -176,6 +180,12 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> >                 else
> >                         err = -ENOTSUPP;
> >                 break;
> > +       case MTK_PIN_CONFIG_RSEL:
> > +               if (hw->soc->rsel_get)
> > +                       err = hw->soc->rsel_get(hw, desc, &ret);
> > +               else
> > +                       err = -EOPNOTSUPP;
> 
> I think that should want to be -ENOTSUPP to align other occurrences.
==>Hi sean,
Can you give me some suggestion? -ENOPARAM or -EBADTYPE?

Thanks.
> 
> > +               break;
> >         default:
> >                 err = -ENOTSUPP;
> >         }
> > @@ -295,6 +305,12 @@ static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
> >                 else
> >                         err = -ENOTSUPP;
> >                 break;
> > +       case MTK_PIN_CONFIG_RSEL:
> > +               if (hw->soc->rsel_set)
> > +                       err = hw->soc->rsel_set(hw, desc, arg);
> > +               else
> > +                       err = -EOPNOTSUPP;
> 
> Ditto
> 
> > +               break;
> >         default:
> >                 err = -ENOTSUPP;
> >         }
> > --
> > 2.18.0
> >