linux-kernel - Re: [PATCH] staging: rtl8723bs: avoid bogus gcc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Apr 2021 17:25:44 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Fabio Aiuto <fabioaiuto83@...il.com>,
        Ross Schmidt <ross.schm.dev@...il.com>,
        Marco Cesati <marcocesati@...il.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Ivan Safonov <insafonov@...il.com>,
        linux-staging@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: avoid bogus gcc warning

On Thu, Apr 22, 2021 at 5:19 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Thu, Apr 22, 2021 at 03:32:04PM +0200, Arnd Bergmann wrote:
> > @@ -762,7 +764,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa
> >               }
> >
> >       }
> > -
>
> Since you're going to need to redo this, then please don't do this
> unrelated whitespace change.
>
> > +#if 1
>
> These seems unintetional?
>

Indeed, both (and another removed line) are artifacts from debugging
that ended up making it into the commit by accident. Sending v2 now.

       Arnd