linux-kernel - Re: [PATCH] Input: rework USB Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74e04402-58b3-b1e5-4f72-9fe227f21b35@infradead.org>
Date:   Thu, 22 Apr 2021 09:32:27 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: rework USB Kconfig dependencies

On 4/22/21 6:36 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A lot of input drivers traditionally depend on CONFIG_USB_ARCH_HAS_HCD
> and select CONFIG_USB. This works but is different from almost every
> other subsystem in the kernel.
> 
> I found this when debugging a build failure in the RC subsystem that
> had the same logic.
> 
> The problem here is that CONFIG_USB_ARCH_HAS_HCD no longer has
> a meaning since the host controller support has been changed to
> use machine specific loadable modules for the USB host. Selecting
> a subsystem that a driver needs is confusing and can lead to
> recursive dependency chains in Kconfig.
> 
> In both cases, the normal logic is to specify 'depends on USB'.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/input/joystick/Kconfig    |  6 ++----
>  drivers/input/misc/Kconfig        | 15 +++++----------
>  drivers/input/mouse/Kconfig       |  9 +++------
>  drivers/input/tablet/Kconfig      | 15 +++++----------
>  drivers/input/touchscreen/Kconfig |  3 +--
>  5 files changed, 16 insertions(+), 32 deletions(-)
> 


-- 
~Randy