linux-kernel - Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <616ec71e-8ca1-c31d-80e2-c064864678a9@linuxfoundation.org>
Date:   Fri, 23 Apr 2021 12:54:19 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Trevor Woerner <twoerner@...il.com>, linux-kernel@...r.kernel.org
Cc:     Jonathan Corbet <corbet@....net>, Jiri Kosina <trivial@...nel.org>,
        Joe Perches <joe@...ches.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Yorick de Wid <yorickdewid@...rs.noreply.github.com>,
        Dan Williams <dan.j.williams@...el.com>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] coding-style.rst: trivial: fix location of driver model
 macros

On 4/23/21 12:40 PM, Trevor Woerner wrote:
> The dev_printk()-like functions moved to include/linux/dev_print.h in
> commit af628aae8640 ("device.h: move dev_printk()-like functions to
> dev_printk.h").
> 
> Signed-off-by: Trevor Woerner <twoerner@...il.com>
> ---
>   Documentation/process/coding-style.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 42969ab37b34..44f796ba52c4 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period.
>   
>   Printing numbers in parentheses (%d) adds no value and should be avoided.
>   
> -There are a number of driver model diagnostic macros in <linux/device.h>
> +There are a number of driver model diagnostic macros in <linux/dev_printk.h>
>   which you should use to make sure messages are matched to the right device
>   and driver, and are tagged with the right level:  dev_err(), dev_warn(),
>   dev_info(), and so forth.  For messages that aren't associated with a
> 

Looks good to me. Thanks for catching this.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah