linux-kernel - Re: [PATCH] openrisc: Fix a memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210423211939.GP3288043@lianli.shorne-pla.net>
Date:   Sat, 24 Apr 2021 06:19:39 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     jonas@...thpole.se, stefan.kristiansson@...nalahti.fi,
        rppt@...nel.org, akpm@...ux-foundation.org, arnd@...db.de,
        openrisc@...ts.librecores.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] openrisc: Fix a memory leak

On Fri, Apr 23, 2021 at 05:09:28PM +0200, Christophe JAILLET wrote:
> 'setup_find_cpu_node()' take a reference on the node it returns.
> This reference must be decremented when not needed anymore, or there will
> be a leak.
> 
> Add the missing 'of_node_put(cpu)'.
> 
> Note that 'setup_cpuinfo()' that also calls this function already has a
> correct 'of_node_put(cpu)' at its end.

Thanks, this looks good to me.  I will queue it up.

> Fixes: 9d02a4283e9c ("OpenRISC: Boot code")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  arch/openrisc/kernel/setup.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
> index 2416a9f91533..c6f9e7b9f7cb 100644
> --- a/arch/openrisc/kernel/setup.c
> +++ b/arch/openrisc/kernel/setup.c
> @@ -278,6 +278,8 @@ void calibrate_delay(void)
>  	pr_cont("%lu.%02lu BogoMIPS (lpj=%lu)\n",
>  		loops_per_jiffy / (500000 / HZ),
>  		(loops_per_jiffy / (5000 / HZ)) % 100, loops_per_jiffy);
> +
> +	of_node_put(cpu);
>  }
>  
>  void __init setup_arch(char **cmdline_p)
> -- 
> 2.27.0
>