linux-kernel - Re: [PATCH v3 0/5] RISC-V: Add kexec/kdump support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-c073ca02-d152-4ef5-86c5-4bcf58154afc@palmerdabbelt-glaptop>
Date:   Thu, 22 Apr 2021 20:48:21 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     mick@....forth.gr
CC:     mick@....forth.gr, linux-riscv@...ts.infradead.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-kernel@...r.kernel.org
Subject:     Re: [PATCH v3 0/5] RISC-V: Add kexec/kdump support

On Thu, 22 Apr 2021 20:36:56 PDT (-0700), mick@....forth.gr wrote:
> Στις 2021-04-23 06:30, Palmer Dabbelt έγραψε:
>> On Mon, 05 Apr 2021 01:57:07 PDT (-0700), mick@....forth.gr wrote:
>>> This patch series adds kexec/kdump and crash kernel
>>> support on RISC-V. For testing the patches a patched
>>> version of kexec-tools is needed (still a work in
>>> progress) which can be found at:
>>>
>>> https://riscv.ics.forth.gr/kexec-tools-patched.tar.xz
>>>
>>> v3:
>>>  * Rebase on newer kernel tree
>>>  * Minor cleanups
>>>  * Split UAPI changes to a separate patch
>>>  * Improve / cleanup init_resources
>>>  * Resolve Palmer's comments
>>>
>>> v2:
>>>  * Rebase on newer kernel tree
>>>  * Minor cleanups
>>>  * Properly populate the ioresources tre, so that it
>>>    can be used later on for implementing strict /dev/mem
>>>  * Use linux,usable-memory on /memory instead of a new binding
>>>  * USe a reserved-memory node for ELF core header
>>>
>>> Nick Kossifidis (5):
>>>   RISC-V: Add EM_RISCV to kexec UAPI header
>>>   RISC-V: Add kexec support
>>>   RISC-V: Improve init_resources
>>>   RISC-V: Add kdump support
>>>   RISC-V: Add crash kernel support
>>>
>>>  arch/riscv/Kconfig                  |  25 ++++
>>>  arch/riscv/include/asm/elf.h        |   6 +
>>>  arch/riscv/include/asm/kexec.h      |  54 +++++++
>>>  arch/riscv/kernel/Makefile          |   6 +
>>>  arch/riscv/kernel/crash_dump.c      |  46 ++++++
>>>  arch/riscv/kernel/crash_save_regs.S |  56 +++++++
>>>  arch/riscv/kernel/kexec_relocate.S  | 222
>>> ++++++++++++++++++++++++++++
>>>  arch/riscv/kernel/machine_kexec.c   | 193 ++++++++++++++++++++++++
>>>  arch/riscv/kernel/setup.c           | 113 ++++++++------
>>>  arch/riscv/mm/init.c                | 110 ++++++++++++++
>>>  include/uapi/linux/kexec.h          |   1 +
>>>  11 files changed, 787 insertions(+), 45 deletions(-)
>>>  create mode 100644 arch/riscv/include/asm/kexec.h
>>>  create mode 100644 arch/riscv/kernel/crash_dump.c
>>>  create mode 100644 arch/riscv/kernel/crash_save_regs.S
>>>  create mode 100644 arch/riscv/kernel/kexec_relocate.S
>>>  create mode 100644 arch/riscv/kernel/machine_kexec.c
>>
>> Thanks.  There were some minor issues and some merge conflicts, I put
>> this on for-next with some fixups.
>
> I've sent a v4 that shouldn't have merge conflicts, addressing some
> comments from Alex as well, could you use that instead or is it too late
> ?

Thanks, for some reason I didn't see it when poking around.  There was 
still that one init_resources() merge conflict and I fixed up some of 
the commit texts, it's now on for-next as

b94394119804 (HEAD -> for-next, riscv/for-next) RISC-V: Add crash kernel support
6e8451782c90 RISC-V: Add kdump support
0a0652429bdb RISC-V: Improve init_resources()
d9a8897d6b5d RISC-V: Add kexec support
f59938095b94 RISC-V: Add EM_RISCV to kexec UAPI header