linux-kernel - Re: [PATCH] soc: qcom-geni-se: remove redundant initialization to variable line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06eab84e-db3d-44a5-44d8-5e09bd876283@kernel.org>
Date:   Fri, 23 Apr 2021 06:09:58 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Colin King <colin.king@...onical.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org, linux-serial@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom-geni-se: remove redundant initialization to
 variable line

On 22. 04. 21, 14:58, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable line being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/serial/qcom_geni_serial.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 99375d99f6fa..c5f2a4fa2bb1 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1338,7 +1338,7 @@ static const struct uart_ops qcom_geni_uart_pops = {
>   static int qcom_geni_serial_probe(struct platform_device *pdev)
>   {
>   	int ret = 0;
> -	int line = -1;
> +	int line;
>   	struct qcom_geni_serial_port *port;
>   	struct uart_port *uport;
>   	struct resource *res;
> 


-- 
js
suse labs