linux-kernel - Re: [PATCH net-next v3 0/6] provide generic net selftest support

Open Source and information security mailing list archives

Message-ID: <20210423043729.tup7nntmmyv6vurm@pengutronix.de>
Date:   Fri, 23 Apr 2021 06:37:29 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Fugang Duan <fugang.duan@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Fabio Estevam <festevam@...il.com>,
        David Jander <david@...tonic.nl>,
        Russell King <linux@...linux.org.uk>,
        Philippe Schenker <philippe.schenker@...adex.com>
Subject: Re: [PATCH net-next v3 0/6] provide generic net selftest support

Hi Joakim,

On Fri, Apr 23, 2021 at 03:18:32AM +0000, Joakim Zhang wrote:
> 
> Hi Oleksij,
> 
> I look both stmmac selftest code and this patch set. For stmmac, if PHY doesn't support loopback, it will fallthrough to MAC loopback.
> You provide this generic net selftest support based on PHY loopback, I have a question, is it possible to extend it also support MAC loopback later?

Yes. If you have interest and time to implement it, please do.
It should be some kind of generic callback as phy_loopback() and if PHY
and MAC loopbacks are supported we need to tests both variants.

Best regards,
Oleksij

> > -----Original Message-----
> > From: Oleksij Rempel <o.rempel@...gutronix.de>
> > Sent: 2021年4月19日 21:01
> > To: Shawn Guo <shawnguo@...nel.org>; Sascha Hauer
> > <s.hauer@...gutronix.de>; Andrew Lunn <andrew@...n.ch>; Florian Fainelli
> > <f.fainelli@...il.com>; Heiner Kallweit <hkallweit1@...il.com>; Fugang
> > Duan <fugang.duan@....com>
> > Cc: Oleksij Rempel <o.rempel@...gutronix.de>; kernel@...gutronix.de;
> > netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>; Fabio
> > Estevam <festevam@...il.com>; David Jander <david@...tonic.nl>; Russell
> > King <linux@...linux.org.uk>; Philippe Schenker
> > <philippe.schenker@...adex.com>
> > Subject: [PATCH net-next v3 0/6] provide generic net selftest support
> > 
> > changes v3:
> > - make more granular tests
> > - enable loopback for all PHYs by default
> > - fix allmodconfig build errors
> > - poll for link status update after switching to the loopback mode
> > 
> > changes v2:
> > - make generic selftests available for all networking devices.
> > - make use of net_selftest* on FEC, ag71xx and all DSA switches.
> > - add loopback support on more PHYs.
> > 
> > This patch set provides diagnostic capabilities for some iMX, ag71xx or any DSA
> > based devices. For proper functionality, PHY loopback support is needed.
> > So far there is only initial infrastructure with basic tests.
> > 
> > Oleksij Rempel (6):
> >   net: phy: execute genphy_loopback() per default on all PHYs
> >   net: phy: genphy_loopback: add link speed configuration
> >   net: add generic selftest support
> >   net: fec: make use of generic NET_SELFTESTS library
> >   net: ag71xx: make use of generic NET_SELFTESTS library
> >   net: dsa: enable selftest support for all switches by default
> > 
> >  drivers/net/ethernet/atheros/Kconfig      |   1 +
> >  drivers/net/ethernet/atheros/ag71xx.c     |  20 +-
> >  drivers/net/ethernet/freescale/Kconfig    |   1 +
> >  drivers/net/ethernet/freescale/fec_main.c |   7 +
> >  drivers/net/phy/phy.c                     |   3 +-
> >  drivers/net/phy/phy_device.c              |  35 +-
> >  include/linux/phy.h                       |   1 +
> >  include/net/dsa.h                         |   2 +
> >  include/net/selftests.h                   |  12 +
> >  net/Kconfig                               |   4 +
> >  net/core/Makefile                         |   1 +
> >  net/core/selftests.c                      | 400
> > ++++++++++++++++++++++
> >  net/dsa/Kconfig                           |   1 +
> >  net/dsa/slave.c                           |  21 ++
> >  14 files changed, 500 insertions(+), 9 deletions(-)  create mode 100644
> > include/net/selftests.h  create mode 100644 net/core/selftests.c
> > 
> > --
> > 2.29.2
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives