linux-kernel - Re: [PATCH 123/190] Revert "netfilter: ip6t

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIJYZWuBnr8+5/sg@kroah.com>
Date:   Fri, 23 Apr 2021 07:17:25 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     linux-kernel@...r.kernel.org, Kangjie Lu <kjlu@....edu>
Subject: Re: [PATCH 123/190] Revert "netfilter: ip6t_srh: fix NULL pointer
 dereferences"

On Thu, Apr 22, 2021 at 11:26:15PM +0200, Pablo Neira Ayuso wrote:
> Hi Greg,
> 
> On Wed, Apr 21, 2021 at 02:59:58PM +0200, Greg Kroah-Hartman wrote:
> > This reverts commit 6d65561f3d5ec933151939c543d006b79044e7a6.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> 
> This patch looks correct, no need to revert.

Wonderful, thanks for the review.

> If you still prefer to revert it, no problem, I'll recover this fix
> via the netfilter tree later on.

Nah, I'm dropping anything that reviewers point out is "ok" from this
patch series.

thanks again,

greg k-h