linux-kernel - Re: [PATCH] tools/cgroup/slabinfo.py: updated to work on current kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIIaZEPdnmXbSMgL@carbon>
Date:   Thu, 22 Apr 2021 17:52:52 -0700
From:   Roman Gushchin <guro@...com>
To:     Vasily Averin <vvs@...tuozzo.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        <linux-kernel@...r.kernel.org>, Michal Hocko <mhocko@...nel.org>
Subject: Re: [PATCH] tools/cgroup/slabinfo.py: updated to work on current
 kernel

On Thu, Apr 22, 2021 at 08:29:31AM +0300, Vasily Averin wrote:
> slabinfo.py script does not work with actual kernel version.
> First, it was unable to recognise SLUB susbsytem,
> when I specified it manually, it was failed again with
> AttributeError: 'struct page' has no member 'obj_cgroups'
> ... and then again with
>   File "tools/cgroup/memcg_slabinfo.py", line 221, in main
>     memcg.kmem_caches.address_of_(),
> AttributeError: 'struct mem_cgroup' has no member 'kmem_caches'
> 
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>

Indeed, we forgot to update it after recent changes in page->memcg_data.
Thank you, Vasily, for updating it!

I tested it, and it works great for me. Please, feel free to add
Tested-by: Roman Gushchin <guro@...com>
Acked-by: Roman Gushchin <guro@...com>

Thanks!