linux-kernel - Re: [PATCH] KVM: x86/xen: Take srcu lock when accessing kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+CxcqMW-m7WNmMv6uP3DusPTWmizf3AwOh9tY43HgrugBg@mail.gmail.com>
Date:   Fri, 23 Apr 2021 16:15:18 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, kvm <kvm@...r.kernel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH] KVM: x86/xen: Take srcu lock when accessing kvm_memslots()

On Fri, 23 Apr 2021 at 16:13, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> On 23/04/21 09:11, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@...cent.com>
> >
> > kvm_memslots() will be called by kvm_write_guest_offset_cached() so
> > take the srcu lock.
> >
> > Signed-off-by: Wanpeng Li <wanpengli@...cent.com>
>
> Good catch.  But I would pull it from kvm_steal_time_set_preempted to
> kvm_arch_vcpu_put instead.

Will do. :)

    Wanpeng