linux-kernel - Re: [patch 5/6] futex: Prepare futex_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877dktwbwv.ffs@nanos.tec.linutronix.de>
Date:   Fri, 23 Apr 2021 12:08:48 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Lukasz Majewski <lukma@...x.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Adhemerval Zanella <adhemerval.zanella@...aro.org>,
        Florian Weimer <fweimer@...hat.com>,
        Carlos O'Donell <carlos@...hat.com>,
        "Michael Kerrisk \(man-pages\)" <mtk.manpages@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Ingo Molnar <mingo@...nel.org>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Darren Hart <dvhart@...radead.org>,
        Andrei Vagin <avagin@...il.com>
Subject: Re: [patch 5/6] futex: Prepare futex_lock_pi() for runtime clock selection

On Fri, Apr 23 2021 at 11:34, Lukasz Majewski wrote:
>>  	ret = get_futex_key(uaddr, flags & FLAGS_SHARED, &q.key,
>> FUTEX_WRITE); @@ -3711,7 +3711,7 @@ long do_futex(u32 __user *uaddr,
>> int op, 
>>  	if (op & FUTEX_CLOCK_REALTIME) {
>>  		flags |= FLAGS_CLOCKRT;
>> -		if (cmd != FUTEX_WAIT_BITSET &&	cmd !=
>> FUTEX_WAIT_REQUEUE_PI)
>> +		if (cmd != FUTEX_WAIT_BITSET && cmd !=
>> FUTEX_WAIT_REQUEUE_PI) return -ENOSYS;
>
> What is the exact change for those two lines above? Looks like some
> different tab/spaces...

Oops. Yes. I surely stared at every hunk more than once...