linux-kernel - Re: [PATCH] KVM: hyper-v: Add new exit reason HYPERV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67ff6513-5275-a94d-ae63-f2fc47769dfc@amazon.com>
Date:   Fri, 23 Apr 2021 12:18:31 +0200
From:   Alexander Graf <graf@...zon.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        Siddharth Chandrasekaran <sidcha@...zon.de>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        <x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>
CC:     Evgeny Iakovlev <eyakovl@...zon.de>, Liran Alon <liran@...zon.com>,
        Ioannis Aslanidis <iaslan@...zon.de>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: hyper-v: Add new exit reason HYPERV_OVERLAY



On 23.04.21 12:15, Paolo Bonzini wrote:
> CAUTION: This email originated from outside of the organization. Do not 
> click links or open attachments unless you can confirm the sender and 
> know thecontent is safe.
> 
> 
> 
> On 23/04/21 11:58, Alexander Graf wrote:
>>> In theory userspace doesn't know how KVM wishes to implement the
>>> hypercall page, especially if Xen hypercalls are enabled as well.
>>
>> I'm not sure I agree with that sentiment :). User space is the one that
>> sets the xen compat mode. All we need to do is declare the ORing as part
>> of the KVM ABI. Which we effectively are doing already, because it's
>> part of the ABI to the guest, no?
> 
> Good point.  But it may change in the future based on KVM_ENABLE_CAP or
> whatever, and duplicating code between userspace and kernel is ugly.  We
> already have too many unwritten conventions around CPUID, MSRs, get/set
> state ioctls, etc.

Yes, I agree. So we can just declare that there won't be any changes to 
the hcall page in-kernel handling code going forward, no? :)

If you want to support a new CAP, support an actual overlay page first - 
and thus actually respect the TLFS.

> That said, this definitely tilts the balance against adding an ioctl to
> write the hypercall page contents.  Userspace can either use the
> KVM_SET_MSR or assemble it on its own, and one of the two should be okay.

Sounds great. And in the future if we need to move the Xen offset, we 
should rather make the Xen offsetting a parameter from user space.


Alex



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879