linux-kernel - Re: [PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3371e3d9-752c-b301-a28e-f043c869ecdf@ideasonboard.com>
Date:   Fri, 23 Apr 2021 15:12:08 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Clark <rob.clark@...aro.org>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly
 documented functions

On 16/04/2021 17:37, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/gpu/drm/omapdrm/omap_irq.c:114: warning: expecting prototype for enable_vblank(). Prototype was for omap_irq_enable_vblank() instead
>   drivers/gpu/drm/omapdrm/omap_irq.c:140: warning: expecting prototype for disable_vblank(). Prototype was for omap_irq_disable_vblank() instead
> 
> Cc: Tomi Valkeinen <tomba@...nel.org>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Rob Clark <rob.clark@...aro.org>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>   drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c
> index 15148d4b35b57..dff095c864909 100644
> --- a/drivers/gpu/drm/omapdrm/omap_irq.c
> +++ b/drivers/gpu/drm/omapdrm/omap_irq.c
> @@ -99,7 +99,7 @@ int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable)
>   }
>   
>   /**
> - * enable_vblank - enable vblank interrupt events
> + * omap_irq_enable_vblank - enable vblank interrupt events
>    * @crtc: DRM CRTC
>    *
>    * Enable vblank interrupts for @crtc.  If the device doesn't have
> @@ -129,7 +129,7 @@ int omap_irq_enable_vblank(struct drm_crtc *crtc)
>   }
>   
>   /**
> - * disable_vblank - disable vblank interrupt events
> + * omap_irq_disable_vblank - disable vblank interrupt events
>    * @crtc: DRM CRTC
>    *
>    * Disable vblank interrupts for @crtc.  If the device doesn't have
> 

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

  Tomi