linux-kernel - Re: [PATCH v5 05/13] module: Add printk formats to add module build ID to stacktraces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dabbab72-7534-66e2-21e1-6e0005bdc2d7@rasmusvillemoes.dk>
Date:   Fri, 23 Apr 2021 15:45:56 +0200
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Stephen Boyd <swboyd@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Jessica Yu <jeyu@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        linux-doc@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v5 05/13] module: Add printk formats to add module build
 ID to stacktraces

On 23/04/2021 15.24, Andy Shevchenko wrote:
> On Thu, Apr 22, 2021 at 04:46:40PM -0700, Stephen Boyd wrote:

>>>> +#include <linux/kernel.h>
>>>
>>> What do you need this header for?
>>>
>>
>> For typeof_member().
> 
> Argh... We really need to split this and container_of to something else. Having
> entire kernel.h for that is an overkill.
> 

Yeah, we should have a type-macros.h (or type-helpers or whatever) that
doesn't include any other kernel headers, just stddef.h (which is
compiler-provided) for offsetof(), providing

typeof_member
sizeof_member
container_of
same_type
type_min
type_max
is_signed_type
__choose_type

or whatever their names are currently.