linux-kernel - Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Apr 2021 16:32:05 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Chen Yu <yu.c.chen@...el.com>
Cc:     Calvin Walton <calvin.walton@...stin.ca>,
        Terry Bowman <terry.bowman@....com>, lenb@...nel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        wei.huang2@....com, aros@....com, rui.zhang@...el.com
Subject: Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on
 AMD processors

On Fri, Apr 23, 2021 at 09:34:30PM +0800, Chen Yu wrote:
> I see, I'll add Calvin's SOB here. Previously I thought the 'From' field might
> be enough to indicate the Author, but it seems to not be the case.

The From: field is used by git to take the author but that's not the
problem. You need the author her/himself to sign off on the work - no
one else can do that.

You can refresh on that here:

Documentation/process/submitting-patches.rst

> Got it. The off_t was derived from old code in this file from get_msr() and alike,
> let me convert this return value to unsigned int.

See my reply to Calvin - it needs to by off_t after all.

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg