linux-kernel - Re: [PATCH] mips/bcm63xx: Use BUG_ON instead of if condition followed by BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <800fd777-dc61-07e0-bc13-bb95a0924335@gmail.com>
Date:   Fri, 23 Apr 2021 08:45:41 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     zhouchuangao <zhouchuangao@...o.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        bcm-kernel-feedback-list@...adcom.com, linux-mips@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips/bcm63xx: Use BUG_ON instead of if condition followed
 by BUG



On 4/23/2021 1:30 AM, zhouchuangao wrote:
> BUG_ON uses unlikely in if(), it can be optimized at compile time.
> 
> Usually, the condition in if() is not satisfied. In my opinion,
> this can improve the efficiency of the multi-stage pipeline.
> 
> Signed-off-by: zhouchuangao <zhouchuangao@...o.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Subject prefix should have been: MIPS: BCM63XX: Use BUG_ON instead of
condition followed by BUG to match prior submissions done to this
directory. Thanks.
-- 
Florian