linux-kernel - Re: [3/3,v3] tools/power turbostat: Enable accumulate RAPL display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP+8YyE2KKgrxF+RV_iYao8Hc5vSjXiRPZ39WzL6Yj2qZ3QL8w@mail.gmail.com>
Date:   Sat, 24 Apr 2021 12:50:30 +0200
From:   Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>
To:     Chen Yu <yu.c.chen@...el.com>
Cc:     Doug Smythies <dsmythies@...us.net>,
        Bingsong Si <owen.si@...oud.cn>,
        youling257 <youling257@...il.com>, erwanaliasr1@...il.com,
        lenb@...nel.org, rjw@...ysocki.net,
        LKML <linux-kernel@...r.kernel.org>,
        Len Brown <len.brown@...el.com>,
        Zhang Rui <rui.zhang@...el.com>
Subject: Re: [3/3,v3] tools/power turbostat: Enable accumulate RAPL display

(apologies for resend, seems my client switched to HTML before)

On Sat, Apr 24, 2021 at 3:40 AM Chen Yu <yu.c.chen@...el.com> wrote:
>
> Hi Bas Nieuwenhuizen,
> On Fri, Mar 12, 2021 at 09:41:14PM +0800, Chen Yu wrote:
> > Hi Youling, Bas, and Bingsong,
> > On Wed, Mar 10, 2021 at 04:03:31PM -0800, Doug Smythies wrote:
> > > Hi Yu,
> > >
> > > I am just resending your e-mail, adjusting the "To:" list to
> > > include the 3 others that have submitted similar patches.
> > >
> > > ... Doug
> > >
> > Could you please help check if the following combined patch works?
> >
> > Thanks,
> > Chenyu
> >
> >
> > From 00e0622b1b693a5c7dc343aeb3aa51614a9e125e Mon Sep 17 00:00:00 2001
> > From: Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>
> > Date: Fri, 12 Mar 2021 21:27:40 +0800
> > Subject: [PATCH] tools/power/turbostat: Fix turbostat for AMD Zen CPUs
> >
> > It was reported that on Zen+ system turbostat started exiting,
> > which was tracked down to the MSR_PKG_ENERGY_STAT read failing because
> > offset_to_idx wasn't returning a non-negative index.
> >
> > This patch combined the modification from Bingsong Si and
> > Bas Nieuwenhuizen and addd the MSR to the index system as alternative for
> > MSR_PKG_ENERGY_STATUS.
> >
> > Fixes: 9972d5d84d76 ("tools/power turbostat: Enable accumulate RAPL display")
> > Reported-by: youling257 <youling257@...il.com>
> > Co-developed-by: Bingsong Si <owen.si@...oud.cn>
> > Signed-off-by: Chen Yu <yu.c.chen@...el.com>
> >
> Can I add your SOB here if you are not object to it?

Yes, seems fine by me. Thanks!

>
> thanks,
> Chenyu