linux-kernel - Re: [PATCH 4/4] misc: eeprom_93xx46: Switch based on word size, not addrlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIQgPwtzaEJDprHo@latitude>
Date:   Sat, 24 Apr 2021 15:42:23 +0200
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Aswath Govindraju <a-govindraju@...com>,
        Vadym Kochan <vadym.kochan@...ision.eu>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 4/4] misc: eeprom_93xx46: Switch based on word size, not
 addrlen

On Sat, Apr 24, 2021 at 02:30:33PM +0200, Emmanuel Gil Peyrot wrote:
> This avoids using magic numbers based on the total size and length of an
> address, where we only want to differentiate between 8-bit and 16-bit,
> and finally makes 93c56 and 93c66 usable!
> 
> If the two pointer indirections is too much, we could move the flags to
> the main struct instead, but I doubt it’s going to make any sensible
> difference.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> ---

Ah, this somewhat addresses my reply to the previous patch.
I think by rearranging and/or squashing the patches, they could tell a
more coherent story, and cause less confusion.

(Basically: avoid creating conditions where the code is wrong — if a
 later patch is needed in order to make a previous patch correct, but the
 later patch alone wouldn't make the code incorrect, swap them. If there's
 breakage either way and you can't tease them apart, squash them together.)



Thanks,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)