linux-kernel - Re: [RESEND PATCH] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161929592285.189809.16598700064500451755.b4-ty@bootlin.com>
Date:   Sat, 24 Apr 2021 22:25:41 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Qinglang Miao <miaoqinglang@...wei.com>,
        Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com>,
        Boris Brezillon <boris.brezillon@...labora.com>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-kernel@...r.kernel.org, linux-i3c@...ts.infradead.org
Subject: Re: [RESEND PATCH] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"

On Thu, 8 Apr 2021 10:28:03 -0700, Jae Hyun Yoo wrote:
> Adding the destroy_workqueue call in i3c_master_register introduced below
> kernel warning because it makes duplicate destroy_workqueue calls when
> i3c_master_register fails after allocating the workqueue. The workqueue will
> be destroyed by i3c_masterdev_release which is called by put_device at the
> end of the i3c_master_register function eventually in failure cases so the
> workqueue doesn't need to be destroyed in i3c_master_register.
> 
> [...]

Applied, thanks!

[1/1] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"
      commit: 0d95f41ebde40d552bb4fea64b1d618607915fd6

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@...tlin.com>