linux-kernel - Re: [PATCH] tools/memory-model: Correct the name of smp_mb__after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210424042704.GR975577@paulmck-ThinkPad-P17-Gen-1>
Date:   Fri, 23 Apr 2021 21:27:04 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Palmer Dabbelt <palmer@...belt.com>
Cc:     mingo@...nel.org, stern@...land.harvard.edu,
        parri.andrea@...il.com, will@...nel.org, peterz@...radead.org,
        boqun.feng@...il.com, npiggin@...il.com, dhowells@...hat.com,
        j.alglave@....ac.uk, luc.maranget@...ia.fr, akiyks@...il.com,
        Daniel Lustig <dlustig@...dia.com>, joel@...lfernandes.org,
        elver@...gle.com, Palmer Dabbelt <palmerdabbelt@...gle.com>,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        kernel-team@...roid.com
Subject: Re: [PATCH] tools/memory-model: Correct the name of
 smp_mb__after_spinlock()

On Fri, Apr 23, 2021 at 05:25:09PM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@...gle.com>
> 
> This was missing one of the double _s.  I only found it because I
> mis-typed the name myself.
> 
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

Good catch, and thank you, but Björn Töpel beat you to it.

dce310f2e546 ("tools/memory-model: Fix smp_mb__after_spinlock() spelling")

This one is queued in the -rcu tree for the v5.14 merge window.

But please keep the fixes coming!

							Thanx, Paul

> ---
>  tools/memory-model/Documentation/explanation.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
> index f9d610d5a1a4..5d72f3112e56 100644
> --- a/tools/memory-model/Documentation/explanation.txt
> +++ b/tools/memory-model/Documentation/explanation.txt
> @@ -2510,7 +2510,7 @@ they behave as follows:
>  	smp_mb__after_atomic() orders po-earlier atomic updates and
>  	the events preceding them against all po-later events;
>  
> -	smp_mb_after_spinlock() orders po-earlier lock acquisition
> +	smp_mb__after_spinlock() orders po-earlier lock acquisition
>  	events and the events preceding them against all po-later
>  	events.
>  
> -- 
> 2.31.1.498.g6c1eba8ee3d-goog
>