linux-kernel - Re: [PATCH v1 1/2] ALSA: hda/cirrus: Set Initial DMIC volume for Bullseye to 16%

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr1iy4vzt.wl-tiwai@suse.de>
Date:   Sun, 25 Apr 2021 10:19:18 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>,
        Stefan Binding <sbinding@...nsource.cirrus.com>,
        You-Sheng Yang <vicamo.yang@...onical.com>
Subject: Re: [PATCH v1 1/2] ALSA: hda/cirrus: Set Initial DMIC volume for Bullseye to 16%

On Sat, 24 Apr 2021 16:32:43 +0200,
Vitaly Rodionov wrote:
> 
> From: Stefan Binding <sbinding@...nsource.cirrus.com>
> 
> Tested on DELL Inspiron-3505, DELL Inspiron-3501, DELL Inspiron-3500

Could you give a bit more descriptions why this patch is needed?
And what do you mean 16%?  The only meaningful measure is dB in the
h/w spec.  Last but not least, why this value was chosen?


thanks,

Takashi

> 
> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
> Signed-off-by: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1923557
> Reported-and-tested-by: You-Sheng Yang <vicamo.yang@...onical.com>
> ---
>  sound/pci/hda/patch_cirrus.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
> index 5d57096b3a95..d6cf93b7483c 100644
> --- a/sound/pci/hda/patch_cirrus.c
> +++ b/sound/pci/hda/patch_cirrus.c
> @@ -2172,6 +2172,10 @@ static void cs8409_cs42l42_fixups(struct hda_codec *codec,
>  			(get_wcaps(codec, CS8409_CS42L42_AMIC_PIN_NID) | AC_WCAP_UNSOL_CAP));
>  		break;
>  	case HDA_FIXUP_ACT_PROBE:
> +
> +		if (codec->fixup_id == CS8409_BULLSEYE)
> +			snd_hda_codec_amp_init_stereo(codec, CS8409_CS42L42_DMIC_ADC_PIN_NID,
> +					HDA_INPUT, 0, 0xff, 0x19);
>  		snd_hda_gen_add_kctl(&spec->gen,
>  			NULL, &cs8409_cs42l42_hp_volume_mixer);
>  		snd_hda_gen_add_kctl(&spec->gen,
> -- 
> 2.25.1
>