linux-kernel - Re: [PATCH] MIPS:DTS:Correct device id and class code of pcie for Loongnon-2K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60a86212-d0d4-7c3f-8ccd-20532fbf4b0c@loongson.cn>
Date:   Sun, 25 Apr 2021 20:05:44 +0800
From:   Xiaochuan Mao <maoxiaochuan@...ngson.cn>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Qing Zhang <zhangqing@...ngson.cn>
Cc:     devicetree@...r.kernel.org,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS:DTS:Correct device id and class code of pcie for
 Loongnon-2K


On 2021/4/25 下午6:39, Jiaxun Yang wrote:
>
> On Sun, Apr 25, 2021, at 1:28 PM, Xiaochuan Mao wrote:
>> from Loongson-2K user manual know that Loongson-2K have two
>> pcie controller pcie0 and pcie1, pcie0 have four port named port0~port3
>> and pcie1 have 2 port named port0~port1. the device id of port0 is 7a19
>> in each pcie controller and others are 7a09. and their class code is 0b0300.
> The manual is obviously incorrect.
>
> class0604 is PCI to PCI bridge that matches. hardware. 0b03 is undefined.
>
> Thanks.
thanks your suggest ,  is my mistake .
>> Signed-off-by: Xiaochuan Mao <maoxiaochuan@...ngson.cn>
>> ---
>>  .../boot/dts/loongson/loongson64-2k1000.dtsi  | 40 +++++++++----------
>>  1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi 
>> b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> index 569e814def83..a95121359080 100644
>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> @@ -150,8 +150,8 @@
>>  			pci_bridge@9,0 {
>>  				compatible = "pci0014,7a19.0",
>>  						   "pci0014,7a19",
>> -						   "pciclass060400",
>> -						   "pciclass0604";
>> +						   "pciclass0b0300",
>> +						   "pciclass0b03";
>>  
>>  				reg = <0x4800 0x0 0x0 0x0 0x0>;
>>  				#interrupt-cells = <1>;
>> @@ -163,10 +163,10 @@
>>  			};
>>  
>>  			pci_bridge@a,0 {
>> -				compatible = "pci0014,7a19.0",
>> -						   "pci0014,7a19",
>> -						   "pciclass060400",
>> -						   "pciclass0604";
>> +				compatible = "pci0014,7a09.0",
>> +						   "pci0014,7a09",
>> +						   "pciclass0b0300",
>> +						   "pciclass0b03";
>>  
>>  				reg = <0x5000 0x0 0x0 0x0 0x0>;
>>  				#interrupt-cells = <1>;
>> @@ -178,10 +178,10 @@
>>  			};
>>  
>>  			pci_bridge@b,0 {
>> -				compatible = "pci0014,7a19.0",
>> -						   "pci0014,7a19",
>> -						   "pciclass060400",
>> -						   "pciclass0604";
>> +				compatible = "pci0014,7a09.0",
>> +						   "pci0014,7a09",
>> +						   "pciclass0b0300",
>> +						   "pciclass0b03";
>>  
>>  				reg = <0x5800 0x0 0x0 0x0 0x0>;
>>  				#interrupt-cells = <1>;
>> @@ -193,10 +193,10 @@
>>  			};
>>  
>>  			pci_bridge@c,0 {
>> -				compatible = "pci0014,7a19.0",
>> -						   "pci0014,7a19",
>> -						   "pciclass060400",
>> -						   "pciclass0604";
>> +				compatible = "pci0014,7a09.0",
>> +						   "pci0014,7a09",
>> +						   "pciclass0b0300",
>> +						   "pciclass0b03";
>>  
>>  				reg = <0x6000 0x0 0x0 0x0 0x0>;
>>  				#interrupt-cells = <1>;
>> @@ -210,8 +210,8 @@
>>  			pci_bridge@d,0 {
>>  				compatible = "pci0014,7a19.0",
>>  						   "pci0014,7a19",
>> -						   "pciclass060400",
>> -						   "pciclass0604";
>> +						   "pciclass0b0300",
>> +						   "pciclass0b03";
>>  
>>  				reg = <0x6800 0x0 0x0 0x0 0x0>;
>>  				#interrupt-cells = <1>;
>> @@ -223,10 +223,10 @@
>>  			};
>>  
>>  			pci_bridge@e,0 {
>> -				compatible = "pci0014,7a19.0",
>> -						   "pci0014,7a19",
>> -						   "pciclass060400",
>> -						   "pciclass0604";
>> +				compatible = "pci0014,7a09.0",
>> +						   "pci0014,7a09",
>> +						   "pciclass0b0300",
>> +						   "pciclass0b03";
>>  
>>  				reg = <0x7000 0x0 0x0 0x0 0x0>;
>>  				#interrupt-cells = <1>;
>> -- 
>> 2.17.1
>>
>>
>
-- 
--xiaochuan