linux-kernel - Re: [PATCH 06/78] media: renesas-ceu: fix pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 25 Apr 2021 19:36:12 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
cc:     linux-media@...r.kernel.org, linuxarm@...wei.com,
        mauro.chehab@...wei.com, linux-media@...r.kernel.org,
        Jacopo Mondi <jacopo@...ndi.org>, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, kbuild-all@...ts.01.org
Subject: Re: [PATCH 06/78] media: renesas-ceu: fix pm_runtime_get_sync()
 usage count (fwd)

Should there be an unlock before line 1104?

thanks,
julia

---------- Forwarded message ----------
Date: Sun, 25 Apr 2021 06:51:17 +0800
From: kernel test robot <lkp@...el.com>
To: kbuild@...ts.01.org
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 06/78] media: renesas-ceu: fix pm_runtime_get_sync() usage
    count

CC: kbuild-all@...ts.01.org
In-Reply-To: <29ba3fafde4d2643fae49789e6b378d6b1fd51f5.1619191723.git.mchehab+huawei@...nel.org>
References: <29ba3fafde4d2643fae49789e6b378d6b1fd51f5.1619191723.git.mchehab+huawei@...nel.org>
TO: Mauro Carvalho Chehab <mchehab@...nel.org>
CC: linux-media@...r.kernel.org
CC: linuxarm@...wei.com
CC: mauro.chehab@...wei.com
CC: Mauro Carvalho Chehab <mchehab@...nel.org>
CC: linux-media@...r.kernel.org
CC: Jacopo Mondi <jacopo@...ndi.org>
CC: linux-kernel@...r.kernel.org
CC: linux-renesas-soc@...r.kernel.org

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on rockchip/for-next tegra/for-next v5.12-rc8 next-20210423]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-use-pm_runtime_resume_and_get-instead-of-pm_runtime_get_sync/20210424-145029
base:   git://linuxtv.org/media_tree.git master
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Julia Lawall <julia.lawall@...6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/media/platform/renesas-ceu.c:1104:2-8: preceding lock on line 1100

vim +1104 drivers/media/platform/renesas-ceu.c

32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1090
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1091  static int ceu_open(struct file *file)
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1092  {
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1093  	struct ceu_device *ceudev = video_drvdata(file);
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1094  	int ret;
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1095
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1096  	ret = v4l2_fh_open(file);
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1097  	if (ret)
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1098  		return ret;
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1099
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22 @1100  	mutex_lock(&ceudev->mlock);
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1101  	/* Causes soft-reset and sensor power on on first open */
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24  1102  	ret = pm_runtime_resume_and_get(ceudev->dev);
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24  1103  	if (ret < 0)
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 @1104  		return ret;
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24  1105
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1106  	mutex_unlock(&ceudev->mlock);
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1107
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1108  	return 0;
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1109  }
32e5a70dc8f4e9 Jacopo Mondi          2018-02-22  1110

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (68970 bytes)