| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Apr 2021 20:02:22 +0200
From: Neil Armstrong <narmstrong@...libre.com>
To: Qiheng Lin <linqiheng@...wei.com>,
Kevin Hilman <khilman@...libre.com>
Cc: linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] soc: amlogic: meson-clk-measure: remove redundant
dev_err call in meson_msr_probe()
On 09/04/2021 13:02, Qiheng Lin wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Qiheng Lin <linqiheng@...wei.com>
> ---
> drivers/soc/amlogic/meson-clk-measure.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
> index e1957476a006..6dd190270123 100644
> --- a/drivers/soc/amlogic/meson-clk-measure.c
> +++ b/drivers/soc/amlogic/meson-clk-measure.c
> @@ -626,10 +626,8 @@ static int meson_msr_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(base)) {
> - dev_err(&pdev->dev, "io resource mapping failed\n");
> + if (IS_ERR(base))
> return PTR_ERR(base);
> - }
>
> priv->regmap = devm_regmap_init_mmio(&pdev->dev, base,
> &meson_clk_msr_regmap_config);
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
Acked-by: Neil Armstrong <narmstrong@...libre.com>
Powered by blists - more mailing lists