linux-kernel - Re: [PATCH v2 2/3] misc: eeprom_93xx46: Add new 93c56 and 93c66 compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIZyFnld4LcR6+Nd@latitude>
Date:   Mon, 26 Apr 2021 09:56:06 +0200
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Jonathan Neuschäfer <j.ne@...teo.net>,
        linux-kernel@...r.kernel.org,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Aswath Govindraju <a-govindraju@...com>,
        Vadym Kochan <vadym.kochan@...ision.eu>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] misc: eeprom_93xx46: Add new 93c56 and 93c66
 compatible strings

On Sat, Apr 24, 2021 at 11:25:42PM +0200, Emmanuel Gil Peyrot wrote:
> These two devices have respectively 2048 and 4096 bits of storage,
> compared to 1024 for the 93c46.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> ---

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@....net>


>  drivers/misc/eeprom/eeprom_93xx46.c | 35 ++++++++++++++++++++++++++---
>  include/linux/eeprom_93xx46.h       |  3 +++
>  2 files changed, 35 insertions(+), 3 deletions(-)

One thing, so it doesn't go unmentioned: There is another driver for
these EEPROMs, drivers/misc/eeprom/eeprom_93cx6.c, but it isn't
stand-alone, it doesn't even have a probe function AFAICT.
In that sense, I agree with the decision to extend this driver instead
of the other one.


Thanks,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)