linux-kernel - Re: ingenic-adc.c:undefined reference to `clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdZ6v7zV4_4YJ-rXAE2_ZLZw04AHib1yGPiwYS_JYYGOg@mail.gmail.com>
Date:   Mon, 26 Apr 2021 11:22:29 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     kernel test robot <lkp@...el.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Subject: Re: ingenic-adc.c:undefined reference to `clk_get_parent'

On Mon, Apr 26, 2021 at 8:43 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> [add linux-clk + maintainers]
>
> On 3/16/21 8:54 AM, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   1a4431a5db2bf800c647ee0ed87f2727b8d6c29c
> > commit: a07a4fe5ff460e99293c0d682421920d54e31d7f iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h
> > date:   8 months ago
> > config: mips-randconfig-p001-20210316 (attached as .config)
> > compiler: mips-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a07a4fe5ff460e99293c0d682421920d54e31d7f
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout a07a4fe5ff460e99293c0d682421920d54e31d7f
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> >>> ingenic-adc.c:(.text+0x8c): undefined reference to `clk_get_parent'
> >    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> >    ingenic-adc.c:(.text+0x164): undefined reference to `clk_get_parent'
>
> Hi,
>
> My guess (analysis) suggests that this problem is due to
> a difference in when clk_get_parent() is available between
> <linux/clk.h> where it depends on CONFIG_HAVE_CLK and
> drivers/clk/clk.c, which is built iff CONFIG_COMMON_CLK.
>
> Any comments/suggestions?

I haven't looked into it, but IIRC MIPS has its own clock API
implementation (or I mixed it with another arch?) and that's the root
of many issues like this around the kernel.

-- 
With Best Regards,
Andy Shevchenko